Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum go version to 1.20 #331

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Bump minimum go version to 1.20 #331

merged 1 commit into from
Jun 1, 2023

Conversation

ghost
Copy link

@ghost ghost commented May 31, 2023

Description

This bumps the minimum go version for VMClarity to 1.20. There are a lot of useful additions in 1.20 such as the strings.Cut and the ability to wrap multiple errors from the errors package.

As part of moving to 1.20 we also need to upgrade golangci-lint to 1.52 as the older version does not seem to work with the newer golang code.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[X] Other (please describe) Golang Bump

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@ghost ghost self-requested a review as a code owner May 31, 2023 11:14
This bumps the minimum go version for VMClarity to 1.20. There are a lot
of useful additions in 1.20 such as the strings.Cut and the ability to
wrap multiple errors from the errors package.

As part of moving to 1.20 we also need to upgrade golangci-lint to 1.52
as the older version does not seem to work with the newer golang code.
@chrisgacsal chrisgacsal added this pull request to the merge queue Jun 1, 2023
Merged via the queue into main with commit b832e70 Jun 1, 2023
5 checks passed
@chrisgacsal chrisgacsal deleted the bump_go120 branch June 1, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants