Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plumb secret scanning in #35

Merged
merged 8 commits into from
Jan 24, 2023
Merged

Plumb secret scanning in #35

merged 8 commits into from
Jan 24, 2023

Conversation

FrimIdan
Copy link
Member

@FrimIdan FrimIdan commented Jan 22, 2023 •
edited

  • Configure secrets config in families config in job management
  • Export secrets finding from the cli
  • Fix some status code handling issues
  • Silence cli usage when an error occurs
  • Update gitleaks finding json tags for the unmarshal logic to work

@FrimIdan FrimIdan changed the title [Draft] Plumb secret scanning in Plumb secret scanning in Jan 22, 2023
@FrimIdan FrimIdan requested review from a user and akpsgit and removed request for fishkerez and a user January 22, 2023 14:48
FrimIdan
FrimIdan commented Jan 22, 2023
View reviewed changes
api/openapi.yaml Outdated Show resolved Hide resolved
akpsgit
akpsgit reviewed Jan 22, 2023
View reviewed changes
api/openapi.yaml Outdated Show resolved Hide resolved
akpsgit
akpsgit reviewed Jan 22, 2023
View reviewed changes
api/openapi.yaml Outdated Show resolved Hide resolved
akpsgit
akpsgit reviewed Jan 22, 2023
View reviewed changes
api/openapi.yaml Outdated Show resolved Hide resolved
akpsgit
akpsgit reviewed Jan 23, 2023
View reviewed changes
cli/cmd/root.go Outdated Show resolved Hide resolved
fishkerez
fishkerez reviewed Jan 23, 2023
View reviewed changes
api/openapi.yaml Show resolved Hide resolved
runtime_scan/pkg/scanner/job_managment_test.go Outdated Show resolved Hide resolved
@FrimIdan FrimIdan requested review from akpsgit and fishkerez and removed request for akpsgit and fishkerez January 24, 2023 06:01
@FrimIdan FrimIdan merged commit 1e7af48 into main Jan 24, 2023
@FrimIdan FrimIdan deleted the plumb-secret-scanning-in branch January 24, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akpsgit akpsgit akpsgit approved these changes

@fishkerez fishkerez Awaiting requested review from fishkerez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FrimIdan @akpsgit @fishkerez