Ensure we cast to JSON while build JSON objects #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that while building the json objects for select and expand, we cast the extracted data to json to avoid issues where the DB gets confused between JSON encoded strings and JSON data. Without this change we sometimes get unexpected escaped quotes in the returned data as the DB thinks its been given a string, but its actually a json encoded string.
ghost
force-pushed
the
sqlite_index_json_bug
branch
from
73883f7
to
1033c96
Compare
chrisgacsal
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit ensures that while building the json objects for select and expand, we cast the extracted data to json to avoid issues where the DB gets confused between JSON encoded strings and JSON data.
Without this change we sometimes get unexpected escaped quotes in the returned data as the DB thinks its been given a string, but its actually a json encoded string.
Type of Change
[X] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist