Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use Google UUID library #378

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Conversation

chrisgacsal
Copy link
Contributor

@chrisgacsal chrisgacsal commented Jun 7, 2023

Description

Use only the github.com/google/uuid instead of mixing the use of the github.com/google/uuid and github.com/satori/go.uuid libraries for generating and handling UUIDs.

Also the latest version of github.com/satori/go.uuid has a high severity CVE-2021-3538.

Another alternative is https://github.com/gofrs/uuid which is a community maintained fork of github.com/satori/go.uuid and it seems to be actively maintained.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chrisgacsal chrisgacsal requested a review from a team as a code owner June 7, 2023 17:15
@chrisgacsal chrisgacsal self-assigned this Jun 7, 2023
@chrisgacsal chrisgacsal added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jun 7, 2023
go.mod Show resolved Hide resolved
@chrisgacsal chrisgacsal added this pull request to the merge queue Jun 8, 2023
Merged via the queue into main with commit d06d753 Jun 8, 2023
5 checks passed
@chrisgacsal chrisgacsal deleted the consolidate-uuid-lib branch June 8, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants