Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use CamelCase for naming
make
ScanResult
states more generic and granular to be applicable for different type of assets (VM, Dir, Pod, etc)INIT
Pending
ScanResult
waiting for being scheduledScheduled
ScanResult
which has been scheduled onProvider
ATTACHED
ReadyToScan
Provider
acknowledged that scan forScanResult
is ready to runABORTED
Aborted
ScanResult
has been aborted and thevmclarity-scanner
needs to cancel all running scanners and shutdown gracefullyIN_PROGRESS
InProgress
vmclarity-scanner
is running scanners on AssetDONE
Done
vmclarity-scanner
has finished with running all scanners on AssetNOT_SCANNED
NotScanned
ScanResult
modify
ScanResultWatcher
by splitting the reconcile logic to handlePending
andScheduled
states separatelyrename
WaitForAttachment
invmclarity-scanner
toWaitForReadyState
as the correspondingATTACHED
state has been changed toReadyToScan
.Type of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist