Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend skeleteon #4

Merged
merged 15 commits into from
Nov 21, 2022
Merged

backend skeleteon #4

merged 15 commits into from
Nov 21, 2022

Conversation

fishkerez
Copy link
Contributor

No description provided.

ghost
ghost reviewed Nov 17, 2022
View reviewed changes
backend/go.mod Show resolved Hide resolved
@FrimIdan
Copy link
Member

@fishkerez please update the make license stuff as in apiclarity
https://github.com/openclarity/apiclarity/blob/master/Makefile#L140-L155
we need cache in each sub folder that we have go.mod in it and we need to run it in each sub module
in order to create the cache locally first you can use github private token and set GITHUB_TOKEN env var locally
more info https://github.com/goph/licensei#github-authentication

FrimIdan
FrimIdan reviewed Nov 17, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Dockerfile.backend Outdated Show resolved Hide resolved
backend/cmd/backend/main.go Outdated Show resolved Hide resolved
backend/cmd/backend/main.go Outdated Show resolved Hide resolved
backend/go.mod Show resolved Hide resolved
backend/go.mod Show resolved Hide resolved
backend/pkg/backend/backend.go Outdated Show resolved Hide resolved
backend/pkg/backend/backend.go Outdated Show resolved Hide resolved
@fishkerez
Copy link
Contributor Author

@fishkerez please update the make license stuff as in apiclarity https://github.com/openclarity/apiclarity/blob/master/Makefile#L140-L155 we need cache in each sub folder that we have go.mod in it and we need to run it in each sub module in order to create the cache locally first you can use github private token and set GITHUB_TOKEN env var locally more info https://github.com/goph/licensei#github-authentication

Why are we not doing it in KubeClarity?

@FrimIdan
Copy link
Member

Why are we not doing it in KubeClarity?

We should

@fishkerez fishkerez merged commit 03c2625 into main Nov 21, 2022
@fishkerez fishkerez deleted the backend-skeleton-new branch November 21, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbalogh-sa pbalogh-sa pbalogh-sa left review comments

@akpsgit akpsgit akpsgit left review comments

@FrimIdan FrimIdan FrimIdan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fishkerez @FrimIdan @pbalogh-sa @akpsgit