Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws): support in multi-region environment #400

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

chrisgacsal
Copy link
Contributor

@chrisgacsal chrisgacsal commented Jun 12, 2023

Description

Fix bug which prevented the AWS provider to find/create cloud resources in case the Target is in a different AWS region than the VMClarity environment.

Fixes: #396

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chrisgacsal chrisgacsal self-assigned this Jun 12, 2023
@chrisgacsal chrisgacsal added the bug Something isn't working label Jun 12, 2023
Fix AWS provider to properly set region for creating cloud resources.
@chrisgacsal chrisgacsal marked this pull request as ready for review June 12, 2023 14:23
@chrisgacsal chrisgacsal requested a review from a team as a code owner June 12, 2023 14:23
@chrisgacsal
Copy link
Contributor Author

I've verified the changes by running E2E test with success.

@chrisgacsal chrisgacsal added this pull request to the merge queue Jun 12, 2023
Merged via the queue into main with commit 0678a63 Jun 12, 2023
5 checks passed
@chrisgacsal chrisgacsal deleted the fix-aws-multi-region branch June 12, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to scan VMs that run on a different region from the VMClarity's server
1 participant