refactor: reconcile event #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgacsal
force-pushed
the
refactor-reconcile-event
branch
from
62ee0a8
to
6d887ba
Compare
FrimIdan
reviewed
Jun 13, 2023
ghost
previously approved these changes
Jun 13, 2023
chrisgacsal
force-pushed
the
refactor-reconcile-event
branch
from
0033ff7
to
e9c6ceb
Compare
chrisgacsal
force-pushed
the
refactor-reconcile-event
branch
from
e9c6ceb
to
1e2482a
Compare
* extend `ReconcileEvent` interface with `Hash` function returning `string` type which does implement the `comparable` interface required by `map` for types used as keys. * change `common.Queue` to rely on the `ReconcileEvent` type instead of `comparable` to provide more flexibility on how the items pushed to the queue are compared to eachother avoiding duplicated items on the queue. * add logging of items being pushed to the queue or popped from the queue for reconciling.
chrisgacsal
force-pushed
the
refactor-reconcile-event
branch
from
9b1f1fd
to
3ce5fca
Compare
|
Tested in E2E. |
ghost
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ReconcileEventinterface withHashfunction returningstringtype which does implement thecomparableinterface required bymapfor types used as keys.common.Queueto rely on theReconcileEventtype instead ofcomparableto provide more flexibility on how the items pushed to the queue are compared to eachother avoiding duplicated items on the queue.Type of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist