Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve aws volume attachment check #450

Merged
merged 1 commit into from
Jul 6, 2023
Merged

fix: resolve aws volume attachment check #450

merged 1 commit into from
Jul 6, 2023

Conversation

ramizpolic
Copy link
Member

Description

Fixes #448 by searching for attached volume attachment state instead of accessing.
Simplifies the code a bit similarly to IsReady

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@ramizpolic ramizpolic requested a review from a team as a code owner July 6, 2023 15:15
@ramizpolic
fix: resolve aws volume attachment check
5af4e22 
Signed-off-by: Ramiz Polic <ramiz.polic@hotmail.com>
@ramizpolic ramizpolic self-assigned this Jul 6, 2023
@ramizpolic ramizpolic added the bug Something isn't working label Jul 6, 2023
@ramizpolic ramizpolic added this pull request to the merge queue Jul 6, 2023
Merged via the queue into main with commit 5205727 Jul 6, 2023
5 checks passed
@ramizpolic ramizpolic deleted the hotfix/aws-index branch July 6, 2023 16:35
@ramizpolic ramizpolic restored the hotfix/aws-index branch July 13, 2023 10:08
@ramizpolic ramizpolic deleted the hotfix/aws-index branch July 13, 2023 10:08
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fishkerez fishkerez fishkerez approved these changes

Assignees

@ramizpolic ramizpolic

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS Provider: IsAttached Index out of range error
2 participants
@ramizpolic @fishkerez