feat: Collect scanner statistics during AssetScan #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akpsgit
reviewed
Jul 17, 2023
akpsgit
reviewed
Jul 17, 2023
akpsgit
reviewed
Jul 18, 2023
akpsgit
previously approved these changes
Jul 18, 2023
ghost
previously approved these changes
Jul 18, 2023
fishkerez
force-pushed
the
scan-benchmark-api
branch
from
ca5cbcc
to
63a9fc4
Compare
ghost
reviewed
Jul 26, 2023
ghost
reviewed
Jul 26, 2023
ghost
force-pushed
the
scan-benchmark-api
branch
from
a9b402f
to
d7c49ac
Compare
ghost
changed the title
ghost
force-pushed
the
scan-benchmark-api
branch
from
d7c49ac
to
4d1e8b3
Compare
akpsgit
previously approved these changes
Jul 28, 2023
ghost
force-pushed
the
scan-benchmark-api
branch
2 times, most recently
from
61034cb
to
b3d603c
Compare
To be able to dynamically estimate time and cost of scans, we need to gather statistics about the scanned filesystem size and time benchmarks per family per input. This information is exported to the AssetScan where the control plane can use it to estimate the cost of future scans.
ghost
force-pushed
the
scan-benchmark-api
branch
from
b3d603c
to
393899d
Compare
ghost
approved these changes
Jul 31, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To be able to dynamically estimate time and cost of scans, we need to
gather statistics about the scanned filesystem size and time benchmarks
per family per input. This information is exported to the AssetScan
where the control plane can use it to estimate the cost of future scans.
Type of Change
[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)