Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add healthz check to orchestrator and to ui backend #593

Merged
merged 4 commits into from
Aug 25, 2023
Merged

feat: add healthz check to orchestrator and to ui backend #593

merged 4 commits into from
Aug 25, 2023

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Aug 22, 2023 •
edited

Description

#547

  • Small refactor on apiserver to improve consistency with other services (move default configs to config file)
  • Add healthz endpoint to orchestrator service and healthcheck to its container
  • Add healthz endpoint to ui backend service and healthcheck to its container

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta self-assigned this Aug 22, 2023
@paralta paralta added the enhancement New feature or request label Aug 22, 2023
@paralta paralta linked an issue Aug 22, 2023 that may be closed by this pull request
Add healthz or readyz/livez endpoints the golang microservices #547
Closed
@paralta paralta changed the title Add healthz check to orchestrator and to ui backend feat: add healthz check to orchestrator and to ui backend Aug 22, 2023
@paralta paralta marked this pull request as ready for review August 25, 2023 07:55
@paralta paralta requested a review from a team as a code owner August 25, 2023 07:55
chrisgacsal
chrisgacsal requested changes Aug 25, 2023
View reviewed changes
pkg/orchestrator/orchestrator.go Outdated Show resolved Hide resolved
chrisgacsal
chrisgacsal approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the effort!

Just a nit. Could you please add the healthcheck statement for apiserver as well? Just to make sure all services which have healthcheck endpoints are covered. Ty

@paralta
Copy link
Contributor Author

paralta commented Aug 25, 2023

LGTM! Thanks for the effort!

Just a nit. Could you please add the healthcheck statement for apiserver as well? Just to make sure all services which have healthcheck endpoints are covered. Ty

@chrisgacsal That is included in the E2E test PR #539 that is why initially I wanted to merge the other PR first, but it is not blocking this one anyway 😄

Thank you so much for reviewing!

@paralta paralta enabled auto-merge August 25, 2023 14:48
@paralta paralta added this pull request to the merge queue Aug 25, 2023
Merged via the queue into main with commit 4c56b1b Aug 25, 2023
8 checks passed
@paralta paralta deleted the healthz-endpoints branch August 25, 2023 15:27
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

Assignees

@paralta paralta

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add healthz or readyz/livez endpoints the golang microservices
2 participants
@paralta @chrisgacsal