fix(lint): golangci-lint to test multiple modules #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Tehsmash
previously requested changes
Aug 24, 2023
chrisgacsal
force-pushed
the
fix-golangci-for-multi-modules
branch
3 times, most recently
from
b8ebdcf
to
18ef8e1
Compare
adamtagscherer
approved these changes
Aug 25, 2023
chrisgacsal
force-pushed
the
fix-golangci-for-multi-modules
branch
from
18ef8e1
to
a006e44
Compare
The `golangci-lint` does not support monorepo type of projects which means only the root package is tested. This change finds all the Golang packages in the repository and runs `golangci-lint` for each of them.
chrisgacsal
force-pushed
the
fix-golangci-for-multi-modules
branch
from
a006e44
to
d12e065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
golangci-lintdoes not support monorepo type of projects with multiple Go packages which means that currently only the root package is tested.This change finds all the Golang packages in the repository and runs
golangci-lintfor each of them.Type of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[x] Other (please describe)
Checklist