Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apiserver): change odata filter in check uniqueness for containers #618

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Aug 31, 2023

Description

While developing the E2E tests, I noticed that some container and image assets appeared more than once in the DB. This was due to a case mismatch in the ODATA filter when we check for asset uniqueness.

The check for asset is found in the basic test should now always succeed without filtering by terminated assets.

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta added the bug Something isn't working label Aug 31, 2023
@paralta paralta requested a review from a team as a code owner August 31, 2023 15:05
@paralta paralta self-assigned this Aug 31, 2023
@paralta paralta enabled auto-merge August 31, 2023 15:17
@paralta paralta added this pull request to the merge queue Aug 31, 2023
Merged via the queue into main with commit 61b135d Aug 31, 2023
8 checks passed
@paralta paralta deleted the docker-check-uniqueness-fail branch August 31, 2023 16:08
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants