Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lint): failing linter for go modules #620

Merged
merged 4 commits into from
Sep 4, 2023
Merged

fix(lint): failing linter for go modules #620

merged 4 commits into from
Sep 4, 2023

Conversation

chrisgacsal
Copy link
Contributor

@chrisgacsal chrisgacsal commented Sep 1, 2023 •
edited

Description

Fix make lint-go target to fail in case there are linter errors reported.

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chrisgacsal chrisgacsal requested a review from a team as a code owner September 1, 2023 15:34
@chrisgacsal chrisgacsal self-assigned this Sep 1, 2023
Tehsmash
Tehsmash previously approved these changes Sep 1, 2023
View reviewed changes
FrimIdan
FrimIdan reviewed Sep 3, 2023
View reviewed changes
.golangci.yml Show resolved Hide resolved
paralta
paralta approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@paralta paralta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chrisgacsal chrisgacsal added this pull request to the merge queue Sep 4, 2023
Merged via the queue into main with commit e266682 Sep 4, 2023
8 checks passed
@chrisgacsal chrisgacsal deleted the fix-golangci-lint branch September 4, 2023 11:56
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
@chrisgacsal chrisgacsal mentioned this pull request Feb 21, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tehsmash Tehsmash Tehsmash approved these changes

@paralta paralta paralta approved these changes

@FrimIdan FrimIdan Awaiting requested review from FrimIdan

Assignees

@chrisgacsal chrisgacsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chrisgacsal @Tehsmash @FrimIdan @paralta