feat: bump golangci-lint version to 1.54.2 #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgacsal
force-pushed
the
bump-golangci-lint
branch
from
4bf6914
to
4a8997b
Compare
adamtagscherer
approved these changes
Sep 6, 2023
Tehsmash
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump
golangci-lintversion to1.54.2. Thedepguardandtagalignlinters were added since1.52.xwhich are temporarily disabled as former seems to be usefull, but requires a discussion with the team before enabling it while, the latter does not seem to provide much of a value besides making the structs with struct tags a bit more readable/organized.Also fixed a couple of linter errors reported by
gosec.Type of Change
[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist