Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test): build all services when running e2e tests #660

Merged
merged 1 commit into from
Sep 7, 2023
Merged

feat(test): build all services when running e2e tests #660

merged 1 commit into from
Sep 7, 2023

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Sep 7, 2023 •
edited

Description

When running end to end tests with make e2e, build all service images and use them for testing.

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta requested a review from a team as a code owner September 7, 2023 16:12
chrisgacsal
chrisgacsal approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paralta paralta self-assigned this Sep 7, 2023
@paralta paralta added enhancement New feature or request test labels Sep 7, 2023
@paralta paralta added this pull request to the merge queue Sep 7, 2023
Merged via the queue into main with commit 41efac0 Sep 7, 2023
10 checks passed
@paralta paralta deleted the e2e-build-all branch September 7, 2023 17:31
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
@chrisgacsal chrisgacsal mentioned this pull request Feb 21, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

Assignees

@paralta paralta

Labels
enhancement New feature or request test
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paralta @chrisgacsal