Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scan estimation time with parallel scanners #672

Merged
merged 1 commit into from
Sep 14, 2023
Merged

feat: scan estimation time with parallel scanners #672

merged 1 commit into from
Sep 14, 2023

Conversation

fishkerez
Copy link
Contributor

@fishkerez fishkerez commented Sep 11, 2023 •
edited by chrisgacsal

Description

Take number of parallel scanners into consideration of scan time estimation

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@fishkerez fishkerez self-assigned this Sep 11, 2023
@fishkerez fishkerez requested a review from a team as a code owner September 11, 2023 05:35
@chrisgacsal chrisgacsal changed the title scan estimation time with parallel scanners feat: scan estimation time with parallel scanners Sep 12, 2023
akpsgit
akpsgit previously approved these changes Sep 13, 2023
View reviewed changes
Tehsmash
Tehsmash previously approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@Tehsmash Tehsmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there are linter errors to be fixed though

akpsgit
akpsgit previously approved these changes Sep 14, 2023
View reviewed changes
@fishkerez fishkerez dismissed stale reviews from akpsgit and Tehsmash via 28d73bf September 14, 2023 11:12
chrisgacsal
chrisgacsal approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the update.

@fishkerez fishkerez added this pull request to the merge queue Sep 14, 2023
Merged via the queue into main with commit 7263406 Sep 14, 2023
16 checks passed
@fishkerez fishkerez deleted the estimate-parallel-scanners branch September 14, 2023 13:26
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

@Tehsmash Tehsmash Tehsmash left review comments

@akpsgit akpsgit akpsgit left review comments

Assignees

@fishkerez fishkerez

Labels
None yet
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fishkerez @Tehsmash @chrisgacsal @akpsgit