feat(scan estimation): add ttl to scanEstimation and assetScanEstimation #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishkerez
changed the title
chrisgacsal
reviewed
Sep 14, 2023
FrimIdan
reviewed
Sep 20, 2023
chrisgacsal
previously requested changes
Sep 20, 2023
Tehsmash
requested changes
Sep 21, 2023
fishkerez
force-pushed
the
estimation-garbage-collector
branch
from
f9b5095
to
8de58cb
Compare
Tehsmash
reviewed
Sep 21, 2023
Tehsmash
approved these changes
Sep 21, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #603 needed to clean up scanEstimation and assetScanEstimation resources after a period of times.
This PR adds ttl to these resources and clean them up from the DB after this time.
The default ttl for both resources (if not set) is 2 hours
Type of Change
[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist