feat(scanners): Add support to all existing scanners for containers #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrimIdan
reviewed
Sep 19, 2023
Tehsmash
force-pushed
the
container_tar_scanning
branch
2 times, most recently
from
c89713f
to
bfb66cf
Compare
|
@FrimIdan I had to squash because I changed the containerRootfs directory from camel case to all lower case because of the linter and apparently OSX directories are not case sensitive so git thought it already existed and didn't do the rename so when applying the commits for a rebase it broke things. |
FrimIdan
reviewed
Sep 20, 2023
fishkerez
reviewed
Sep 20, 2023
Tehsmash
force-pushed
the
container_tar_scanning
branch
from
bfb66cf
to
faba20d
Compare
This commit adds support to all existing scanners for all families for the image, docker-archive, oci-archive, and oci-directory input types. In the scenario where a scanner does not support containers natively a new library containerrootfs has been added which converts the container into a rootfs folder. The containerrootfs library supports a cached mode which indentifies containers based on the source and cache the result so that multiple scanners (even concurrent ones) attempting to convert the same container to a rootfs only perform it once. All these cached folders are cleaned up by a function called once all the families have completed.
Tehsmash
force-pushed
the
container_tar_scanning
branch
from
faba20d
to
999ff2c
Compare
akpsgit
approved these changes
Sep 21, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds support to all existing scanners for all families for
the image, docker-archive, oci-archive, and oci-directory input types.
In the scenario where a scanner does not support containers natively a
new library containerrootfs has been added which converts the container
into a rootfs folder.
The containerrootfs library supports a cached mode which indentifies
containers based on the source and cache the result so that multiple
scanners (even concurrent ones) attempting to convert the same container
to a rootfs only perform it once. All these cached folders are cleaned
up by a function called once all the families have completed.
Type of Change
[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist