Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(make): remove deprecated clean-backend and run go mod tidy in all modules #705

Merged
merged 5 commits into from
Sep 22, 2023
Merged

fix(make): remove deprecated clean-backend and run go mod tidy in all modules #705

merged 5 commits into from
Sep 22, 2023

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Sep 21, 2023

Description

  • Remove deprecated clean-backend and add clean-go to remove all GO executables
  • Change gomod-tidy to run in all directories with go.mod files

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta added bug Something isn't working enhancement New feature or request labels Sep 21, 2023
@paralta paralta self-assigned this Sep 21, 2023
@paralta paralta requested a review from a team as a code owner September 21, 2023 09:14
Tehsmash
Tehsmash requested changes Sep 21, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
chrisgacsal
chrisgacsal previously approved these changes Sep 21, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
chrisgacsal
chrisgacsal approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :shipit:

@paralta paralta added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit 15e0e42 Sep 22, 2023
16 checks passed
@paralta paralta deleted the fix-makefile branch September 22, 2023 08:11
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
@chrisgacsal chrisgacsal mentioned this pull request Feb 21, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tehsmash Tehsmash Tehsmash approved these changes

@chrisgacsal chrisgacsal chrisgacsal approved these changes

Assignees

@paralta paralta

Labels
bug Something isn't working enhancement New feature or request
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paralta @Tehsmash @chrisgacsal