Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): add allof metadata to assetscan #724

Merged
merged 2 commits into from
Oct 2, 2023
Merged

feat(api): add allof metadata to assetscan #724

merged 2 commits into from
Oct 2, 2023

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Sep 29, 2023 •
edited

Description

Following up on the discussion at #703, add metadata to asset scan API object.

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta requested a review from a team as a code owner September 29, 2023 09:58
@paralta paralta changed the title feat(api): add metadata to assetscan feat(api): add allof metadata to assetscan Sep 29, 2023
@paralta paralta self-assigned this Sep 29, 2023
@paralta paralta added the component:api Issues related to API label Sep 29, 2023
@paralta paralta force-pushed the issue718-add-annotations-to-assetscan branch from dccf3fd to a2c71b5 Compare September 29, 2023 12:42
@paralta paralta added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit e6d0344 Oct 2, 2023
10 checks passed
@paralta paralta deleted the issue718-add-annotations-to-assetscan branch October 2, 2023 08:17
@pbalogh-sa pbalogh-sa mentioned this pull request Oct 2, 2023
Closed
7 tasks
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
@chrisgacsal chrisgacsal mentioned this pull request Feb 21, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akpsgit akpsgit akpsgit approved these changes

Assignees

@paralta paralta

Labels
component:api Issues related to API
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paralta @akpsgit