Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): improve CI pipeline #729

Merged
merged 3 commits into from
Oct 3, 2023
Merged

feat(ci): improve CI pipeline #729

merged 3 commits into from
Oct 3, 2023

Conversation

chrisgacsal
Copy link
Contributor

@chrisgacsal chrisgacsal commented Oct 2, 2023 •
edited
Loading

Description

  • add concurrency to make sure that CI pipeline runs on the latest commit of the Pull Request while all the ongoing runs targeting previous state are cancelled
  • remove unused upload parameter
  • build container images for each platform in parallel

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

TODO

@chrisgacsal chrisgacsal self-assigned this Oct 2, 2023
@chrisgacsal chrisgacsal added the enhancement New feature or request label Oct 2, 2023
@chrisgacsal chrisgacsal marked this pull request as ready for review October 2, 2023 20:46
@chrisgacsal chrisgacsal requested a review from a team as a code owner October 2, 2023 20:46
@chrisgacsal
feat(ci): set concurrency for CI pipeline
67e362e 
Make sure that CI pipeline runs on the latest commit of the Pull Request
and all the ongoing runs targeting previous state are cancelled.
@chrisgacsal
refactor(ci): rm unused upload build parameter
11d2c55
@chrisgacsal
feat(ci): build multi-arch images in parallel
cd0961b
FrimIdan
FrimIdan approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@FrimIdan FrimIdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisgacsal chrisgacsal added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 782ab15 Oct 3, 2023
20 checks passed
@chrisgacsal chrisgacsal deleted the improve-ci branch October 3, 2023 14:10
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
@chrisgacsal chrisgacsal mentioned this pull request Feb 21, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tehsmash Tehsmash Tehsmash approved these changes

@FrimIdan FrimIdan FrimIdan approved these changes

Assignees

@chrisgacsal chrisgacsal

Labels
enhancement New feature or request
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisgacsal @Tehsmash @FrimIdan