Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add effective scan config to assetScan annotations #739

Merged
merged 10 commits into from
Oct 6, 2023
Merged

feat: add effective scan config to assetScan annotations #739

merged 10 commits into from
Oct 6, 2023

Conversation

pbalogh-sa
Copy link
Member

@pbalogh-sa pbalogh-sa commented Oct 4, 2023 •
edited

Description

This PR adds the effective families configuration as an annotation to the assetScan object.
The annotation:

  • key = openclarity.io/vmclarity-scanner/config
  • value = the effective configuration in JSON format

closes: #703

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@pbalogh-sa pbalogh-sa requested a review from a team as a code owner October 4, 2023 14:20
chrisgacsal
chrisgacsal requested changes Oct 4, 2023
View reviewed changes
pkg/cli/state/vmclarity_test.go Outdated Show resolved Hide resolved
Tehsmash
Tehsmash reviewed Oct 5, 2023
View reviewed changes
pkg/cli/state/vmclarity.go Outdated Show resolved Hide resolved
@chrisgacsal chrisgacsal self-requested a review October 5, 2023 09:07
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
Tehsmash
Tehsmash reviewed Oct 6, 2023
View reviewed changes
pkg/cli/state/vmclarity.go Outdated Show resolved Hide resolved
@pbalogh-sa @Tehsmash
Update pkg/cli/state/vmclarity.go
bbb968b 
Co-authored-by: Sam Betts <1769706+Tehsmash@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr739-b03cdbc548bc77012a15760b3c3e743fe0200e81
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr739-b03cdbc548bc77012a15760b3c3e743fe0200e81
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr739-b03cdbc548bc77012a15760b3c3e743fe0200e81
  • ghcr.io/openclarity/vmclarity-ui-dev:pr739-b03cdbc548bc77012a15760b3c3e743fe0200e81
  • ghcr.io/openclarity/vmclarity-cli-dev:pr739-b03cdbc548bc77012a15760b3c3e743fe0200e81

@pbalogh-sa pbalogh-sa self-assigned this Oct 6, 2023
chrisgacsal
chrisgacsal approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@pbalogh-sa pbalogh-sa added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit bec52d7 Oct 6, 2023
26 checks passed
@pbalogh-sa pbalogh-sa deleted the assetscan-effective-sanconfig branch October 6, 2023 10:45
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tehsmash Tehsmash Tehsmash approved these changes

@chrisgacsal chrisgacsal chrisgacsal approved these changes

Assignees

@pbalogh-sa pbalogh-sa

Labels
None yet
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Effective scan configurations for asset scans
3 participants
@pbalogh-sa @Tehsmash @chrisgacsal