Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing DirInfo and PodInfo OData schemas #740

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix: missing DirInfo and PodInfo OData schemas #740

merged 1 commit into from
Oct 5, 2023

Conversation

pbalogh-sa
Copy link
Member

Description

This PR adds the missing OData schema definitions for DirInfo and PodInfo because the openAPI definition contains these objects.

fixes: #738

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@pbalogh-sa pbalogh-sa requested a review from a team as a code owner October 4, 2023 14:48
paralta
paralta approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@paralta paralta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

chrisgacsal
chrisgacsal approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@pbalogh-sa pbalogh-sa added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit 0ace4d8 Oct 5, 2023
20 checks passed
@pbalogh-sa pbalogh-sa deleted the add-missing-odata-schemas branch October 5, 2023 07:21
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

@paralta paralta paralta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing OData schema definitions: DirInfo and PodInfo.
3 participants
@pbalogh-sa @chrisgacsal @paralta