-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add annotations to all high level API objects #765
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'd like to hear @Tehsmash take on this change as well before approving it. Thanks for the effort!
1741a06
to
5316e61
Compare
This comment has been minimized.
This comment has been minimized.
5316e61
to
9a015d9
Compare
This comment has been minimized.
This comment has been minimized.
9a015d9
to
3a08b73
Compare
This comment has been minimized.
This comment has been minimized.
3a08b73
to
53bad30
Compare
This comment has been minimized.
This comment has been minimized.
53bad30
to
36c8154
Compare
This comment has been minimized.
This comment has been minimized.
2de3444
to
8ab83bb
Compare
This comment has been minimized.
This comment has been minimized.
8ab83bb
to
0d7ae50
Compare
Hey! Your images are ready:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But I'd like to get @Tehsmash's input on this change as well.
thank you so much for your reviews 😄 |
Description
Add metadata to all high level API objects (asset, scan, scan config, finding, scan estimation, asset scan estimation).
Type of Change
[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist