feat(api): add annotations to all high level API objects #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
chrisgacsal
reviewed
Oct 10, 2023
There was a problem hiding this comment.
LGTM! I'd like to hear @Tehsmash take on this change as well before approving it. Thanks for the effort!
paralta
force-pushed
the
add-annotations-2-asset
branch
from
1741a06
to
5316e61
Compare
paralta
changed the title
This comment has been minimized.
This comment has been minimized.
paralta
force-pushed
the
add-annotations-2-asset
branch
from
5316e61
to
9a015d9
Compare
This comment has been minimized.
This comment has been minimized.
paralta
force-pushed
the
add-annotations-2-asset
branch
from
9a015d9
to
3a08b73
Compare
This comment has been minimized.
This comment has been minimized.
paralta
force-pushed
the
add-annotations-2-asset
branch
from
3a08b73
to
53bad30
Compare
This comment has been minimized.
This comment has been minimized.
paralta
force-pushed
the
add-annotations-2-asset
branch
from
53bad30
to
36c8154
Compare
This comment has been minimized.
This comment has been minimized.
paralta
force-pushed
the
add-annotations-2-asset
branch
2 times, most recently
from
2de3444
to
8ab83bb
Compare
This comment has been minimized.
This comment has been minimized.
paralta
force-pushed
the
add-annotations-2-asset
branch
from
8ab83bb
to
0d7ae50
Compare
|
Hey! Your images are ready:
|
chrisgacsal
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
LGTM! But I'd like to get @Tehsmash's input on this change as well.
Tehsmash
approved these changes
Oct 12, 2023
|
thank you so much for your reviews 😄 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add metadata to all high level API objects (asset, scan, scan config, finding, scan estimation, asset scan estimation).
Type of Change
[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist