-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(provider): wrong container image name #772
Conversation
Currently looking into the new test failure related with the filter used 👀 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
55985dc
to
3c3bc92
Compare
This comment has been minimized.
This comment has been minimized.
3c3bc92
to
65a3230
Compare
65a3230
to
bc8e963
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Erez's points, lets get those fixed otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Erez's points, lets get those fixed otherwise LGTM.
834c963
to
a962cc9
Compare
This comment has been minimized.
This comment has been minimized.
aa46b14
to
45ed389
Compare
This comment has been minimized.
This comment has been minimized.
45ed389
to
563027b
Compare
Hey! Your images are ready:
|
* feat(api): make container and image id required * feat(provider): remove slash from container name * feat(provider): replace image name with repotags and repodigest * feat(provider): add container and image info to asset type * refactor(provider): code review changes * test(provider): test image asset is found and scanned * refactor(provider): code review changes
Description
The Container Image name is available inside the
RepoTag
field. Included in this PR:Related to #763, but does not fix UI issue.
Type of Change
[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist