Skip to content
This repository has been archived by the owner on Oct 14, 2024. It is now read-only.

feat(e2e): make testenv pluginable #773

Merged
merged 2 commits into from
Oct 12, 2023
Merged

feat(e2e): make testenv pluginable #773

merged 2 commits into from
Oct 12, 2023

Conversation

chrisgacsal
Copy link
Contributor

Description

Add testenv pluginable in order to support running end-to-end test suite on platforms supported by VMClarity.

Type of Change

[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chrisgacsal chrisgacsal requested a review from a team as a code owner October 11, 2023 16:14
@chrisgacsal chrisgacsal self-assigned this Oct 11, 2023
@chrisgacsal chrisgacsal force-pushed the mk-testenv-pluggable branch 6 times, most recently from 4a0477b to 8940761 Compare October 11, 2023 18:12
@github-actions

This comment has been minimized.

Sign in to view
pbalogh-sa
pbalogh-sa previously approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@pbalogh-sa pbalogh-sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, LGTM

paralta
paralta previously approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@paralta paralta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some small suggestions :D

e2e/testenv/testenv_test.go Show resolved Hide resolved
e2e/suite_test.go Show resolved Hide resolved
@chrisgacsal chrisgacsal dismissed stale reviews from paralta and pbalogh-sa via 90d9475 October 12, 2023 08:41
@github-actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr773-2b232b4da4f4c37f7930fb2c8e2662e81fb697ef
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr773-2b232b4da4f4c37f7930fb2c8e2662e81fb697ef
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr773-2b232b4da4f4c37f7930fb2c8e2662e81fb697ef
  • ghcr.io/openclarity/vmclarity-ui-dev:pr773-2b232b4da4f4c37f7930fb2c8e2662e81fb697ef
  • ghcr.io/openclarity/vmclarity-cli-dev:pr773-2b232b4da4f4c37f7930fb2c8e2662e81fb697ef

@chrisgacsal chrisgacsal added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit a61429b Oct 12, 2023
32 checks passed
@chrisgacsal chrisgacsal deleted the mk-testenv-pluggable branch October 12, 2023 10:10
@chrisgacsal chrisgacsal mentioned this pull request Oct 12, 2023
Merged
7 tasks
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
@chrisgacsal chrisgacsal mentioned this pull request Feb 21, 2024
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paralta paralta paralta approved these changes

@pbalogh-sa pbalogh-sa pbalogh-sa left review comments

Assignees

@chrisgacsal chrisgacsal

Labels
None yet
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisgacsal @pbalogh-sa @paralta