fix(ui): name, location, platform, image, launch time of assets

[gallotamas]

Description

Name, location, platform, image and launch time was wrong for ContainerImageInfo and ContainerInfo assets. This PR is fixing them.

Related issue: #763

Screenshots:

• ContainerInfo

• ContainerImageInfo

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

• I have read the contributing guidelines
• Existing issues have been referenced (where applicable)
• I have verified this change is not present in other open pull requests
• Functionality is documented
• All code style checks pass
• New code contribution is covered by automated tests
• All new and existing tests pass

[chrisgacsal]

Awesome! Thanks for fixing it!

[github-actions]

Hey!

Your images are ready:

• ghcr.io/openclarity/vmclarity-apiserver-dev:pr791-bcf47a20db7a4ba9c4359612ebac1b94f77e9aff
• ghcr.io/openclarity/vmclarity-orchestrator-dev:pr791-bcf47a20db7a4ba9c4359612ebac1b94f77e9aff
• ghcr.io/openclarity/vmclarity-ui-backend-dev:pr791-bcf47a20db7a4ba9c4359612ebac1b94f77e9aff
• ghcr.io/openclarity/vmclarity-ui-dev:pr791-bcf47a20db7a4ba9c4359612ebac1b94f77e9aff
• ghcr.io/openclarity/vmclarity-cli-dev:pr791-bcf47a20db7a4ba9c4359612ebac1b94f77e9aff

[chrisgacsal]

Thanks @gallotamas for the fixes! LGTM!

[chrisgacsal]

@Tehsmash Could you please take another look on this one?

[Tehsmash]

This might be out of scope for this PR, but looking at the screenshots shared in the description I'm not sure at this is solving the UX issue that we have. It feels like we're trying to squash all the container and container image specific information into the fields that are specific to the VM asset type. For example why does Container Image Info have an "IMAGE" field...

It feels to me like the page needs to adapt to the type of asset that its displaying, and output the common fields "Type", "First Seen", "Last Seen", "Terminated On" first. Then have an Asset Info section which includes:

• for VMs, we should use the existing fields although Name should be renamed "Instance ID".
• for Container Image assets we should show ImageID, RepoTags and Digests, Architechture, OS, Size.
• for Containers it should have "Labels", "Container Name", "Container ID" + Container Image Info like above.

[chrisgacsal]

This might be out of scope for this PR, but looking at the screenshots shared in the description I'm not sure at this is solving the UX issue that we have. It feels like we're trying to squash all the container and container image specific information into the fields that are specific to the VM asset type. For example why does Container Image Info have an "IMAGE" field...

It feels to me like the page needs to adapt to the type of asset that its displaying, and output the common fields "Type", "First Seen", "Last Seen", "Terminated On" first. Then have an Asset Info section which includes:

* for VMs, we should use the existing fields although Name should be renamed "Instance ID".

* for Container Image assets we should show ImageID, RepoTags and Digests, Architechture, OS, Size.

* for Containers it should have "Labels", "Container Name", "Container ID" + Container Image Info like above.

Yeah, I've discussed this with @gallotamas last week. The main goal here was to fix what is broken. The presentation layer needs a refactor which will include the rework of the details page for assets based on their types.

But this is definitely out of scope for this PR.

@Tehsmash

[Tehsmash]

Yeah, I've discussed this with @gallotamas last week. The main goal here was to fix what is broken. The presentation layer needs a refactor which will include the rework of the details page for assets based on their types.

But this is definitely out of scope for this PR.

@Tehsmash

OK cool as long as we know because honestly these screens make little to no sense right now

[misi-bp]

Yes, @gallotamas showed me the different data objects of types in the openapi.yaml file. This is not just out of scope; unfortunately, much longer work is required to fix it.

[Tehsmash]

Yes, @gallotamas showed me the different data objects of types in the openapi.yaml file. This is not just out of scope; unfortunately, much longer work is required to fix it.

fixing it properly maybe, but javascript supports If assetInfo.objectType == "ContainerImageInfo" { return one set of HTML} else { return other set of HTML }