-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): name, location, platform, image, launch time of assets #791
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for fixing it!
This comment has been minimized.
This comment has been minimized.
Hey! Your images are ready:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gallotamas for the fixes! LGTM!
@Tehsmash Could you please take another look on this one? |
This might be out of scope for this PR, but looking at the screenshots shared in the description I'm not sure at this is solving the UX issue that we have. It feels like we're trying to squash all the container and container image specific information into the fields that are specific to the VM asset type. For example why does Container Image Info have an "IMAGE" field... It feels to me like the page needs to adapt to the type of asset that its displaying, and output the common fields "Type", "First Seen", "Last Seen", "Terminated On" first. Then have an Asset Info section which includes:
|
Yeah, I've discussed this with @gallotamas last week. The main goal here was to fix what is broken. The presentation layer needs a refactor which will include the rework of the details page for assets based on their types. But this is definitely out of scope for this PR. |
OK cool as long as we know because honestly these screens make little to no sense right now |
Yes, @gallotamas showed me the different data objects of types in the openapi.yaml file. This is not just out of scope; unfortunately, much longer work is required to fix it. |
fixing it properly maybe, but javascript supports |
Description
Name, location, platform, image and launch time was wrong for ContainerImageInfo and ContainerInfo assets. This PR is fixing them.
Related issue: #763
Screenshots:
Type of Change
[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist