Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: azure deploy template have wrong values as defaults #805

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

fishkerez
Copy link
Contributor

@fishkerez fishkerez commented Oct 17, 2023

Description

The azure deploy template was still using the old backend name in the advanced section where we should be able to override the defaults. This PR fixes it to use the new services (orchestrator, apiserver etc.)

Type of Change

[* ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

@fishkerez fishkerez self-assigned this Oct 17, 2023
@fishkerez fishkerez requested a review from a team as a code owner October 17, 2023 11:20
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But would love to get others to take a look as well.

@github-actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr805-c2cffa99533cf8a1fade7b02fc463e244cfcfa0c
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr805-c2cffa99533cf8a1fade7b02fc463e244cfcfa0c
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr805-c2cffa99533cf8a1fade7b02fc463e244cfcfa0c
  • ghcr.io/openclarity/vmclarity-ui-dev:pr805-c2cffa99533cf8a1fade7b02fc463e244cfcfa0c
  • ghcr.io/openclarity/vmclarity-cli-dev:pr805-c2cffa99533cf8a1fade7b02fc463e244cfcfa0c

@fishkerez fishkerez added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit 97a50df Oct 17, 2023
32 checks passed
@fishkerez fishkerez deleted the fix-azure-deploy branch October 17, 2023 12:02
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants