Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(api): scanners statuses of AssetScan #825

Merged
merged 28 commits into from
Nov 22, 2023
Merged

refactor(api): scanners statuses of AssetScan #825

merged 28 commits into from
Nov 22, 2023

Conversation

adamtagscherer
Copy link
Contributor

@adamtagscherer adamtagscherer commented Oct 18, 2023 •
edited

Description

Move the statuses of the different scanners from the status property of the AssetScan one step upper to their own property.
This is necessary because the status of the AssetScan differs from the statuses of the scanners and needs to be handled differently.

issue: #664

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@adamtagscherer adamtagscherer added go Pull requests that update Go code component:api Issues related to API labels Oct 18, 2023
@adamtagscherer adamtagscherer self-assigned this Oct 18, 2023
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@adamtagscherer adamtagscherer marked this pull request as ready for review October 30, 2023 10:27
@adamtagscherer adamtagscherer requested a review from a team as a code owner October 30, 2023 10:27
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@chrisgacsal chrisgacsal changed the title Refactor scanners statuses of AssetScan refactor(api): scanners statuses of AssetScan Oct 31, 2023
paralta
paralta reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@paralta paralta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really neat 👍 just added a couple of comments and suggestions, nothing major

api/openapi.yaml Show resolved Hide resolved
pkg/apiserver/database/gorm/odata.go Show resolved Hide resolved
pkg/apiserver/database/demo.go Outdated Show resolved Hide resolved
pkg/cli/presenter/vmclarity.go Outdated Show resolved Hide resolved
pkg/cli/presenter/vmclarity.go Show resolved Hide resolved
pkg/cli/utils/apimodel.go Outdated Show resolved Hide resolved
pkg/cli/utils/apimodel.go Show resolved Hide resolved
pkg/orchestrator/assetscanprocessor/processor.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@adamtagscherer
fix(asset-scan-scanners): run linter
b29e7cc
@adamtagscherer
fix(asset-scan-scanners): db schema
cb835f4
@adamtagscherer
fix(asset-scan-scanners): run linter
15fdeff
@adamtagscherer
fix(asset-scan-scanners): run linter
c8b903c
@adamtagscherer
fix(asset-scan-scanners): run linter
524932c
@adamtagscherer
fix(asset-scan-scanners): run linter
f3eef86
@adamtagscherer
refactor(asset-scan-scanners): rename reasons
62c6045
@adamtagscherer
refactor(asset-scan-scanners): exploits scanner
7d761e0
@adamtagscherer
refactor(asset-scan-scanners): vulnerabilities scanner
83cb4eb
@adamtagscherer
refactor(asset-scan-scanners): malware scanner
d09edc7
@adamtagscherer
refactor(asset-scan-scanners): rootkit scanner
5e3c3bb
@adamtagscherer
refactor(asset-scan-scanners): secret scanner
f246ffd
@adamtagscherer
refactor(asset-scan-scanners): misconfiguration scanner
83c8ce8
@adamtagscherer
refactor(asset-scan-scanners): infofinder scanner
230d555
@adamtagscherer
fix(asset-scan-scanners): linter
6325135
@adamtagscherer
test(asset-scan-scanners): helpers_test.go
7453c0e
@adamtagscherer
test(asset-scan-scanners): helpers_test.go
3a08c9b
@adamtagscherer
fix(asset-scan-scanners): frontend
c237470
@adamtagscherer
fix(asset-scan-scanners): demo scanner statuses
5d30c05
@adamtagscherer
refactor(scanner-statuses): guard nils, remove unnecessary items from…
98fbead 
… the db schema, fix unit tests
@adamtagscherer
refactor(scanner-statuses): add ScannerStatusState prefix to statuses
773ddd6
@adamtagscherer
fix(scanner-statuses): make lint-go
7266c51
@adamtagscherer
refactor(scanner-statuses): reference propert assetScan property
9ae2e26
@adamtagscherer
refactor(scanner-statuses): reorganize presenter code
54716a8
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr825-edfb5e42ae9b8dd8c4e95cebb4e659e0abb0f31c
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr825-edfb5e42ae9b8dd8c4e95cebb4e659e0abb0f31c
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr825-edfb5e42ae9b8dd8c4e95cebb4e659e0abb0f31c
  • ghcr.io/openclarity/vmclarity-ui-dev:pr825-edfb5e42ae9b8dd8c4e95cebb4e659e0abb0f31c
  • ghcr.io/openclarity/vmclarity-cli-dev:pr825-edfb5e42ae9b8dd8c4e95cebb4e659e0abb0f31c

@adamtagscherer adamtagscherer added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 590e2b9 Nov 22, 2023
33 checks passed
@adamtagscherer adamtagscherer deleted the asset-scan-scanners-refactor branch November 22, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paralta paralta paralta left review comments

@chrisgacsal chrisgacsal chrisgacsal approved these changes

Assignees

@adamtagscherer adamtagscherer

Labels
component:api Issues related to API go Pull requests that update Go code
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adamtagscherer @chrisgacsal @paralta