Add support for ODATA $filter, $select and $count on /scanConfigs #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
odata_filter
branch
2 times, most recently
from
f074819
to
19c8cad
Compare
ghost
changed the title
FrimIdan
reviewed
Feb 27, 2023
FrimIdan
reviewed
Feb 27, 2023
FrimIdan
reviewed
Feb 28, 2023
FrimIdan
reviewed
Mar 2, 2023
FrimIdan
reviewed
Mar 2, 2023
ghost
force-pushed
the
odata_filter
branch
2 times, most recently
from
68e2b6c
to
cf07208
Compare
akpsgit
reviewed
Mar 6, 2023
| if err != nil { | ||
| return nil, fmt.Errorf("failed to convert scanID %v to uuid: %v", id, err) | ||
| return ret, fmt.Errorf("failed to convert scanID %v to uuid: %v", scan.Id, err) |
There was a problem hiding this comment.
need to print *scan.Id, right?
akpsgit
reviewed
Mar 6, 2023
akpsgit
reviewed
Mar 6, 2023
| return sc, nil | ||
| } | ||
|
|
||
| func getExistingScanConfigbyID(db *gorm.DB, scanConfig models.ScanConfig) (ScanConfig, error) { |
There was a problem hiding this comment.
we can pass only the id here
akpsgit
reviewed
Mar 6, 2023
|
|
||
| // Fields for complex field types | ||
| ComplexFieldSchemas []string | ||
| DescriminatorProperty string |
akpsgit
reviewed
Mar 6, 2023
|
|
||
| // nolint:gocognit,cyclop | ||
| func (st *selectNode) insert(path []*godata.Token, filter *godata.GoDataFilterQuery, sel *godata.GoDataSelectQuery, subExpand *godata.GoDataExpandQuery, expand bool) error { | ||
| // If path length == 0 then we've reach the bottom of the path and now |
There was a problem hiding this comment.
we've reached the bottom of the path, and ...
akpsgit
reviewed
Mar 6, 2023
| } | ||
|
|
||
| // Parse $select using ParseExpandString because godata.ParseSelectString | ||
| // is a nieve implementation and doesn't handle query options properly |
akpsgit
reviewed
Mar 6, 2023
| } | ||
|
|
||
| // nolint:gocognit,cyclop | ||
| func (st *selectNode) insert(path []*godata.Token, filter *godata.GoDataFilterQuery, sel *godata.GoDataSelectQuery, subExpand *godata.GoDataExpandQuery, expand bool) error { |
There was a problem hiding this comment.
worth putting a todo here to ad a unit test. I think that it will also make it more clear with input and output examples
This commit revisits the database interface such that each function takes in and returns a VMClarity API model object. How the DB driver decides to store these objects and process them efficently is the resposiblity of the DB driver. We start with one DB driver, gorm, which converts the model objects to GORM structs to save them.
* Covers most usecases with a fake DB and dataset * Fixes a couple of bugs with expand * Switches $filter to use / separated paths like $select/$expand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.