-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): separate asset drilldown types #860
Conversation
@Tehsmash @chrisgacsal I've updated the asset details view. Let me know what you think. |
This comment has been minimized.
This comment has been minimized.
Looking good so far @gallotamas! Couple of feedback items:
|
sounds good, thanks for the feedback @Tehsmash |
@Tehsmash I made some changes based on your feedback. Can you take another look? |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment has been minimized.
This comment has been minimized.
ui/src/layout/detail-displays/AssetDetails/CommonAssetMetadata.js
Outdated
Show resolved
Hide resolved
9797030
Hey! Your images are ready:
|
Description
Fix for #804
Create separate details views for the different asset types and only show the relevant fields of specific types.
Screenshots for the different asset types (I don't have a PodInfo and DirInfo asset so I couldn't create a screenshot for them but the views have been updated for them as well):
![image](https://private-user-images.githubusercontent.com/19503754/278638818-5b4121d0-cbc0-4ca3-b467-a5d811bdcd81.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ1MzAxNzQsIm5iZiI6MTcyNDUyOTg3NCwicGF0aCI6Ii8xOTUwMzc1NC8yNzg2Mzg4MTgtNWI0MTIxZDAtY2JjMC00Y2EzLWI0NjctYTVkODExYmRjZDgxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI0VDIwMDQzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUxOWQ3ZWVkMGJmZTllMGU2ZGYwOTg0OTUwNWU3ZTMwZDEyYjNhNzQxZTQ3NDExYjM2Y2YwYjc2NGJkZWEwMDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.2zp9myDLAXkaknFrz82oQqwfey8B55DxbOQVnbgeToI)
VMInfo:
ContainerInfo:
![Screenshot 2023-10-27 at 17 45 36](https://private-user-images.githubusercontent.com/19503754/278694628-50b1213a-0e57-4f0c-8afe-9a403297fe17.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ1MzAxNzQsIm5iZiI6MTcyNDUyOTg3NCwicGF0aCI6Ii8xOTUwMzc1NC8yNzg2OTQ2MjgtNTBiMTIxM2EtMGU1Ny00ZjBjLThhZmUtOWE0MDMyOTdmZTE3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI0VDIwMDQzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg2NWY3YzkzYmQ4MmZkOWE4ODA2ZGZkMDg3ZDE1OGExOGM4ZWQ2NjUzNjQ2MzQxNzkzNDA2NTE2YjQ3ZTFhNzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.VDINeHK90mFyrXK37E5QlURphDbJYbvaD-8zvLlaV9E)
ContainerImageInfo:
![Screenshot 2023-10-27 at 17 46 08](https://private-user-images.githubusercontent.com/19503754/278694711-9f0ba521-bad5-4f19-8bab-517b625a4d97.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ1MzAxNzQsIm5iZiI6MTcyNDUyOTg3NCwicGF0aCI6Ii8xOTUwMzc1NC8yNzg2OTQ3MTEtOWYwYmE1MjEtYmFkNS00ZjE5LThiYWItNTE3YjYyNWE0ZDk3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI0VDIwMDQzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUwMTlkMDVmMmRhM2E4YWJmYThlNGIxMTM5NmNhOGJlMzFlNTdiN2U4ZGU0MTkxNzEyZmQ2NTg3NzM0ZTMyZmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.72f1PbO2UJ2xFGFOLAiiTydPXfo55lJrBtKUqIwCFfE)
Type of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist