feat(k8s): Asset scan support #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tehsmash
changed the title
Tehsmash
force-pushed
the
k8s_scanning
branch
from
e23c141
to
e7921a8
Compare
This comment has been minimized.
This comment has been minimized.
Tehsmash
force-pushed
the
k8s_scanning
branch
from
e7921a8
to
476de30
Compare
akpsgit
reviewed
Nov 2, 2023
Tehsmash
force-pushed
the
k8s_scanning
branch
from
476de30
to
2a727e6
Compare
Tehsmash
changed the title
Tehsmash
force-pushed
the
k8s_scanning
branch
from
2a727e6
to
9039191
Compare
This comment has been minimized.
This comment has been minimized.
Tehsmash
force-pushed
the
k8s_scanning
branch
from
9039191
to
2565d7b
Compare
This comment has been minimized.
This comment has been minimized.
chrisgacsal
force-pushed
the
k8s_scanning
branch
from
2565d7b
to
14bbb11
Compare
This comment has been minimized.
This comment has been minimized.
This was referenced Jan 29, 2024
chrisgacsal
force-pushed
the
k8s_scanning
branch
3 times, most recently
from
3f3e486
to
7c7c1f1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
chrisgacsal
requested review from
adamtagscherer,
ramizpolic,
akijakya and
paralta
paralta
reviewed
Jan 30, 2024
ramizpolic
previously approved these changes
Jan 30, 2024
|
Thanks for the review @paralta and @ramizpolic. I'll address your comments asap. Also wanted to mention that my main goal was to ensure correctness of what is implemented in this PR by limiting the number of changes added on top of the original code. All the optimizations and improvements should be added in following PRs in my honest opinion. Ty |
chrisgacsal
force-pushed
the
k8s_scanning
branch
from
f18551e
to
9234176
Compare
paralta
previously approved these changes
Jan 31, 2024
chrisgacsal
force-pushed
the
k8s_scanning
branch
from
9234176
to
e51b88f
Compare
|
Hey! Your images are ready:
|
ramizpolic
approved these changes
Jan 31, 2024
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add RunAssetScan implementations for running containers and container images to the Kubernetes Provider. It builds on the foundation introduced by the Kubernetes Provider discovery logic to export containers and container images from the container runtime and then run a scanner job to analyse the resulting tar.
Type of Change
[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist