-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(k8s): Asset scan support #864
Conversation
e23c141
to
e7921a8
Compare
This comment has been minimized.
This comment has been minimized.
e7921a8
to
476de30
Compare
476de30
to
2a727e6
Compare
2a727e6
to
9039191
Compare
This comment has been minimized.
This comment has been minimized.
9039191
to
2565d7b
Compare
This comment has been minimized.
This comment has been minimized.
2565d7b
to
14bbb11
Compare
This comment has been minimized.
This comment has been minimized.
3f3e486
to
7c7c1f1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, quite a lot of work here, well done 👍
just added a couple of smaller notes to consider
Thanks for the review @paralta and @ramizpolic. I'll address your comments asap. Also wanted to mention that my main goal was to ensure correctness of what is implemented in this PR by limiting the number of changes added on top of the original code. All the optimizations and improvements should be added in following PRs in my honest opinion. Ty |
f18551e
to
9234176
Compare
9234176
to
e51b88f
Compare
Hey! Your images are ready:
|
Description
Add RunAssetScan implementations for running containers and container images to the Kubernetes Provider. It builds on the foundation introduced by the Kubernetes Provider discovery logic to export containers and container images from the container runtime and then run a scanner job to analyse the resulting tar.
Type of Change
[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist