Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): add empty value indications #868

Merged
merged 13 commits into from
Oct 31, 2023
Merged

fix(ui): add empty value indications #868

merged 13 commits into from
Oct 31, 2023

Conversation

gallotamas
Copy link
Contributor

Description

Fixes #822
Nothing was shown when a field value was empty in a table cell or in the details views.
I created a ValueWithFallback component and used it everywhere I noticed that there were empty values on the UI. The default fallback value is a greyed out dash/hyphen as it was suggested in the referenced issue.

Some screenshots about the result:
Screenshot 2023-10-30 at 14 30 50
Screenshot 2023-10-30 at 14 30 38
Screenshot 2023-10-30 at 14 31 36

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@gallotamas gallotamas requested a review from a team as a code owner October 30, 2023 13:45
@github-actions

This comment has been minimized.

Sign in to view
adamtagscherer
adamtagscherer previously approved these changes Oct 30, 2023
View reviewed changes
@gallotamas gallotamas linked an issue Oct 30, 2023 that may be closed by this pull request
Better empty field value indication #822
Closed
Tehsmash
Tehsmash previously approved these changes Oct 30, 2023
View reviewed changes
Base automatically changed from separate-asset-drilldown-types to main October 31, 2023 08:32
@gallotamas gallotamas dismissed stale reviews from Tehsmash and adamtagscherer October 31, 2023 08:32

The base branch was changed.

@github-actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr868-5550b70975122d255f918c7bf87475f30a89a2b8
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr868-5550b70975122d255f918c7bf87475f30a89a2b8
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr868-5550b70975122d255f918c7bf87475f30a89a2b8
  • ghcr.io/openclarity/vmclarity-ui-dev:pr868-5550b70975122d255f918c7bf87475f30a89a2b8
  • ghcr.io/openclarity/vmclarity-cli-dev:pr868-5550b70975122d255f918c7bf87475f30a89a2b8

@gallotamas gallotamas added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit ffb1f7b Oct 31, 2023
32 checks passed
@gallotamas gallotamas deleted the add-empty-value-indications branch October 31, 2023 09:16
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
Merged
7 tasks
@chrisgacsal chrisgacsal mentioned this pull request Feb 21, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

@Tehsmash Tehsmash Tehsmash left review comments

@adamtagscherer adamtagscherer adamtagscherer left review comments

Assignees

@gallotamas gallotamas

Labels
None yet
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better empty field value indication
4 participants
@gallotamas @Tehsmash @chrisgacsal @adamtagscherer