Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chkrootkit binary detection #883

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix: chkrootkit binary detection #883

merged 1 commit into from
Nov 2, 2023

Conversation

chrisgacsal
Copy link
Contributor

Description

Fallback to the default binary instead of failing if the path for the chkrootkit brinary is not set in the configuration. Fail only if the binary is not available on $PATH either.

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

Fallback to the default binary instead of failing if the path for the
chkrootkit brinary is not set in the configuration. Fail only if the
binary is not available on $PATH either.
@chrisgacsal chrisgacsal requested a review from a team as a code owner November 2, 2023 10:08
@chrisgacsal chrisgacsal self-assigned this Nov 2, 2023
@chrisgacsal chrisgacsal added the bug Something isn't working label Nov 2, 2023
Copy link

github-actions bot commented Nov 2, 2023

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr883-81abb7b3c0a5e832d0c0e3397ab8d88e695edd70
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr883-81abb7b3c0a5e832d0c0e3397ab8d88e695edd70
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr883-81abb7b3c0a5e832d0c0e3397ab8d88e695edd70
  • ghcr.io/openclarity/vmclarity-ui-dev:pr883-81abb7b3c0a5e832d0c0e3397ab8d88e695edd70
  • ghcr.io/openclarity/vmclarity-cli-dev:pr883-81abb7b3c0a5e832d0c0e3397ab8d88e695edd70

Merged via the queue into main with commit 06ef2d1 Nov 2, 2023
32 checks passed
@chrisgacsal chrisgacsal deleted the fix-chkrootkit branch November 2, 2023 11:36
paralta pushed a commit that referenced this pull request Nov 2, 2023
Fallback to the default binary instead of failing if the path for the
chkrootkit brinary is not set in the configuration. Fail only if the
binary is not available on $PATH either.
paralta pushed a commit that referenced this pull request Nov 2, 2023
Fallback to the default binary instead of failing if the path for the
chkrootkit brinary is not set in the configuration. Fail only if the
binary is not available on $PATH either.
github-merge-queue bot pushed a commit that referenced this pull request Nov 2, 2023
Fallback to the default binary instead of failing if the path for the
chkrootkit brinary is not set in the configuration. Fail only if the
binary is not available on $PATH either.

Co-authored-by: Krisztian Gacsal <chrisgacsal@users.noreply.github.com>
paralta pushed a commit that referenced this pull request Nov 2, 2023
Fallback to the default binary instead of failing if the path for the
chkrootkit brinary is not set in the configuration. Fail only if the
binary is not available on $PATH either.

Co-authored-by: Krisztian Gacsal <chrisgacsal@users.noreply.github.com>
paralta pushed a commit that referenced this pull request Nov 2, 2023
Fallback to the default binary instead of failing if the path for the
chkrootkit brinary is not set in the configuration. Fail only if the
binary is not available on $PATH either.

Co-authored-by: Krisztian Gacsal <chrisgacsal@users.noreply.github.com>
paralta pushed a commit that referenced this pull request Nov 2, 2023
Fallback to the default binary instead of failing if the path for the
chkrootkit brinary is not set in the configuration. Fail only if the
binary is not available on $PATH either.

Co-authored-by: Krisztian Gacsal <chrisgacsal@users.noreply.github.com>
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants