fix: lynis testDB path #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgacsal
added
bug
The `lynis show dbdir` command returns the path to the test database directory on the where the output string has a trailing newline character which is not removed before generating the path for the `tests.db` file. This results a bogus file path liek `/usr/local/lynis/db /tests.db` and triggers an error as the `tests.db` file is not accessable. This fix make sure that the command output is sanitized by removing leading/trailing whitespaces and the path is cleaned before using it to assemble the file path for `tests.db`. Switch to `filepath` from `path` for working with filesystem paths as the latter is not meant to be used with OS filesystem paths. Also rename `testdb` variable to `testDB` in order to make it aligned with Go naming convention.
chrisgacsal
force-pushed
the
fix-lynis-testdb-path
branch
from
6512e89
to
8a5ff2f
Compare
paralta
approved these changes
Nov 2, 2023
7 tasks
Tehsmash
approved these changes
Nov 2, 2023
|
Hey! Your images are ready:
|
akpsgit
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
lynis show dbdircommand returns the path to the test database directory where the output string has a trailing newline character which is not removed before generating the path for thetests.dbfile. This results a bogus file path like/usr/local/lynis/db /tests.dband triggers an error as thetests.dbfile is not accessable.This fix make sure that the command output is sanitized by removing leading/trailing whitespaces and the path is cleaned before using it to assemble the file path for
tests.db.Switch to
filepathfrompathfor working with filesystem paths as the latter is not meant to be used with OS filesystem paths.Also rename
testdbvariable totestDBin order to make it aligned with Go naming convention.Type of Change
[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist