-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): calculate completed scans count correctly #898
Conversation
4339cb3
to
37354d8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 thanks for fixing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @adamtagscherer! :)
03445cb
to
16f5ddc
Compare
16f5ddc
to
1f47f0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be using the $filter here instead of loading every scan into the UI and then filtering it. e.g.
$filter=state eq 'Aborted' or state eq 'Failed' or state eq 'Done'
7881ad9
to
ed5438d
Compare
This comment has been minimized.
This comment has been minimized.
ed5438d
to
894937c
Compare
Hey! Your images are ready:
|
I see that "Risky Findings" was changed to "Findings" in https://github.com/openclarity/vmclarity/pull/898/files#diff-a7f123acafc6f879519bf54b3e58eb3ebab608f6d1c23a8107b883eee501e8cfR18 The idea was not to count packages, but only findings with Risks. |
The problem with this was that the label said "Risky Findings" although we queried every finding without narrowing the query at all. |
Description
Fix for: #894
On the Dashboard menu the
Completed scans
widgets shows every scan not only the completed ones.This PR fixes this issue by checking the scans for their state property.
Type of Change
[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist