fix(ui): calculate completed scans count correctly

[adamtagscherer]

Description

Fix for: #894
On the Dashboard menu the Completed scans widgets shows every scan not only the completed ones.
This PR fixes this issue by checking the scans for their state property.

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

• I have read the contributing guidelines
• Existing issues have been referenced (where applicable)
• I have verified this change is not present in other open pull requests
• Functionality is documented
• All code style checks pass
• New code contribution is covered by automated tests
• All new and existing tests pass

[paralta]

LGTM 👍 thanks for fixing this!

[lgecse]

LGTM, thanks @adamtagscherer! :)

[Tehsmash]

I think we should be using the $filter here instead of loading every scan into the UI and then filtering it. e.g.

$filter=state eq 'Aborted' or state eq 'Failed' or state eq 'Done'

[github-actions]

Hey!

Your images are ready:

• ghcr.io/openclarity/vmclarity-apiserver-dev:pr898-05aa82e1afa5675f6ba9a8536687f84152f0d25c
• ghcr.io/openclarity/vmclarity-orchestrator-dev:pr898-05aa82e1afa5675f6ba9a8536687f84152f0d25c
• ghcr.io/openclarity/vmclarity-ui-backend-dev:pr898-05aa82e1afa5675f6ba9a8536687f84152f0d25c
• ghcr.io/openclarity/vmclarity-ui-dev:pr898-05aa82e1afa5675f6ba9a8536687f84152f0d25c
• ghcr.io/openclarity/vmclarity-cli-dev:pr898-05aa82e1afa5675f6ba9a8536687f84152f0d25c

[akpsgit]

I see that "Risky Findings" was changed to "Findings" in https://github.com/openclarity/vmclarity/pull/898/files#diff-a7f123acafc6f879519bf54b3e58eb3ebab608f6d1c23a8107b883eee501e8cfR18

The idea was not to count packages, but only findings with Risks.
Also, maybe worth making such changes if needed in a separated PR.

[adamtagscherer]

I see that "Risky Findings" was changed to "Findings" in https://github.com/openclarity/vmclarity/pull/898/files#diff-a7f123acafc6f879519bf54b3e58eb3ebab608f6d1c23a8107b883eee501e8cfR18

The idea was not to count packages, but only findings with Risks. Also, maybe worth making such changes if needed in a separated PR.

The problem with this was that the label said "Risky Findings" although we queried every finding without narrowing the query at all.
We can change this query to only GET the Risky Findings but then we have to decide which Findings are risky, so what is the definition of a Risky Finding?