Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): show container names and location on asset scans and findings pages #900

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

gallotamas
Copy link
Contributor

@gallotamas gallotamas commented Nov 3, 2023

Description

Fix for #889
The UI did not display names and locations for both Docker images and containers in “Asset Scans” and “Findings” table views. This PR is intended to fix it by show them the same way as it is displayed on the assets page.

Screenshots:
Screenshot 2023-11-03 at 12 47 05
Screenshot 2023-11-03 at 12 47 18

Type of Change

[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

- on asset scans page
- on findings page
@gallotamas gallotamas requested a review from a team as a code owner November 3, 2023 11:54

This comment has been minimized.

@gallotamas gallotamas requested review from Tehsmash and a team November 3, 2023 14:15
Copy link

github-actions bot commented Nov 3, 2023

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr900-7aea1d271690a2fa8ff50349b29bfcaa870ca065
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr900-7aea1d271690a2fa8ff50349b29bfcaa870ca065
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr900-7aea1d271690a2fa8ff50349b29bfcaa870ca065
  • ghcr.io/openclarity/vmclarity-ui-dev:pr900-7aea1d271690a2fa8ff50349b29bfcaa870ca065
  • ghcr.io/openclarity/vmclarity-cli-dev:pr900-7aea1d271690a2fa8ff50349b29bfcaa870ca065

Copy link
Contributor

@paralta paralta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks for fixing this issue!

@gallotamas gallotamas added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit 8ed255a Nov 3, 2023
34 checks passed
@gallotamas gallotamas deleted the container-data-on-asset-scans-and-findings branch November 3, 2023 15:33
@chrisgacsal chrisgacsal mentioned this pull request Nov 6, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants