Revisit Scan API model to allow for ScanConfig expand, snapshot and summary #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
akpsgit
reviewed
Mar 1, 2023
akpsgit
reviewed
Mar 1, 2023
akpsgit
reviewed
Mar 1, 2023
FrimIdan
reviewed
Mar 2, 2023
| @@ -40,7 +40,7 @@ type Scan struct { | |||
| // ScanConfigID The ID of the config that this scan was initiated from (optionanl) | |||
| ScanConfigID *string `json:"scan_config_id,omitempty" gorm:"column:scan_config_id"` | |||
| // ScanFamiliesConfig The configuration of the scanner families within a scan config | |||
| ScanFamiliesConfig []byte `json:"scan_families_config,omitempty" gorm:"column:scan_families_config"` | |||
| ScanConfigSnapshot []byte `json:"scan_families_config,omitempty" gorm:"column:scan_families_config"` | |||
There was a problem hiding this comment.
@sambetts-cisco @akpsgit need to fix the json and gorm tags (scan_families_config)
There was a problem hiding this comment.
also the comment needs fixing
FrimIdan
reviewed
Mar 2, 2023
| reason := models.ScanStateReasonNothingToScan | ||
| scan := &models.Scan{ | ||
| EndTime: &t, | ||
| State: utils.PointerTo[models.ScanState](models.Done), |
There was a problem hiding this comment.
@sambetts-cisco I think that just calling utils.PointerTo(models.Done) will also do the work
fishkerez
reviewed
Mar 2, 2023
| TargetIDs: targetIds, | ||
| State: utils.PointerTo[models.ScanState](models.Discovered), | ||
| StateMessage: utils.PointerTo[string]("Targets for scan successfully discovered"), | ||
| Summary: &models.ScanSummary{ |
There was a problem hiding this comment.
why do we need to define the summary again if it is not changed?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.