Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: remove installing ICU on runner #924

Merged
merged 1 commit into from
Nov 8, 2023
Merged

ci: remove installing ICU on runner #924

merged 1 commit into from
Nov 8, 2023

Conversation

chrisgacsal
Copy link
Contributor

@chrisgacsal chrisgacsal commented Nov 8, 2023 •
edited

Description

Remove installing libicu-dev as it is preinstalled on Ubuntu runners for Github Actions.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[x] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chrisgacsal
ci: remove installing ICU on runner
78d227a 
Remove isntalling `libicu-dev` as it is preinstalled on Ubuntu runners
for Github Actions.
@chrisgacsal chrisgacsal added the ci Continious Integration related PRs label Nov 8, 2023
@chrisgacsal chrisgacsal marked this pull request as ready for review November 8, 2023 10:39
@chrisgacsal chrisgacsal requested a review from a team as a code owner November 8, 2023 10:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr924-d7c7b741de04d83f5978dcb28eca552f2d2c63f8
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr924-d7c7b741de04d83f5978dcb28eca552f2d2c63f8
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr924-d7c7b741de04d83f5978dcb28eca552f2d2c63f8
  • ghcr.io/openclarity/vmclarity-ui-dev:pr924-d7c7b741de04d83f5978dcb28eca552f2d2c63f8
  • ghcr.io/openclarity/vmclarity-cli-dev:pr924-d7c7b741de04d83f5978dcb28eca552f2d2c63f8

@chrisgacsal chrisgacsal added this pull request to the merge queue Nov 8, 2023
Merged via the queue into main with commit fa4ddec Nov 8, 2023
34 checks passed
@chrisgacsal chrisgacsal deleted the rm-icu-install branch November 8, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamtagscherer adamtagscherer adamtagscherer approved these changes

@lgecse lgecse lgecse approved these changes

Assignees
No one assigned
Labels
ci Continious Integration related PRs
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisgacsal @adamtagscherer @lgecse