Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add rfc for e2e type safety #946

Merged
merged 2 commits into from
Nov 21, 2023
Merged

docs: add rfc for e2e type safety #946

merged 2 commits into from
Nov 21, 2023

Conversation

gallotamas
Copy link
Contributor

@gallotamas gallotamas commented Nov 15, 2023 •
edited

Description

Please read the RFC for more details here or in the PR.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[x] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@gallotamas gallotamas requested a review from a team as a code owner November 15, 2023 09:48
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
Tehsmash
Tehsmash requested changes Nov 16, 2023
View reviewed changes
rfc/end-to-end-type-safe-apis.md Show resolved Hide resolved
rfc/end-to-end-type-safe-apis.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr946-e5a2d6f9054076650dc77596c1a8c8086c725429
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr946-e5a2d6f9054076650dc77596c1a8c8086c725429
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr946-e5a2d6f9054076650dc77596c1a8c8086c725429
  • ghcr.io/openclarity/vmclarity-ui-dev:pr946-e5a2d6f9054076650dc77596c1a8c8086c725429
  • ghcr.io/openclarity/vmclarity-cli-dev:pr946-e5a2d6f9054076650dc77596c1a8c8086c725429

chrisgacsal
chrisgacsal approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gallotamas
Copy link
Contributor Author

@Tehsmash Would you like me to change something in this RFC or can I merge it and can we plan it in the future?

Tehsmash
Tehsmash approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@Tehsmash Tehsmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tehsmash Would you like me to change something in this RFC or can I merge it and can we plan it in the future?

No I think its good as is, sorry for the delay re-reviewing it.

@gallotamas gallotamas added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit 0f60c48 Nov 21, 2023
33 checks passed
@gallotamas gallotamas deleted the rfc-for-e2e-type-safety branch November 21, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tehsmash Tehsmash Tehsmash approved these changes

@chrisgacsal chrisgacsal chrisgacsal approved these changes

@ramizpolic ramizpolic ramizpolic approved these changes

Assignees

@gallotamas gallotamas

Labels
rfc
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gallotamas @Tehsmash @chrisgacsal @ramizpolic