Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(gcp): use labels instead of network tags #961

Merged
merged 2 commits into from
Nov 17, 2023
Merged

refactor(gcp): use labels instead of network tags #961

merged 2 commits into from
Nov 17, 2023

Conversation

adamtagscherer
Copy link
Contributor

@adamtagscherer adamtagscherer commented Nov 17, 2023 •
edited

Description

Use labels of the GCP instances instead of their network tags.
Network tags enable you to make firewall rules and routes applicable to specific VM instances, not to help you scan your VM instances with VMClarity.
Labels are a much better fit for this purpose.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@adamtagscherer adamtagscherer added go Pull requests that update Go code provider:gcp Issues relating to the GCP provider test labels Nov 17, 2023
@adamtagscherer adamtagscherer self-assigned this Nov 17, 2023
@adamtagscherer adamtagscherer requested a review from a team as a code owner November 17, 2023 12:31
@adamtagscherer adamtagscherer changed the title refactor(gcp): use labels instead of firewall tags refactor(gcp): use labels instead of network tags Nov 17, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr961-c6f2601cc0f1cc656cde069f674d051f53acb8bc
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr961-c6f2601cc0f1cc656cde069f674d051f53acb8bc
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr961-c6f2601cc0f1cc656cde069f674d051f53acb8bc
  • ghcr.io/openclarity/vmclarity-ui-dev:pr961-c6f2601cc0f1cc656cde069f674d051f53acb8bc
  • ghcr.io/openclarity/vmclarity-cli-dev:pr961-c6f2601cc0f1cc656cde069f674d051f53acb8bc

@adamtagscherer adamtagscherer added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit 7c41e8d Nov 17, 2023
33 checks passed
@adamtagscherer adamtagscherer deleted the gcp-use-instance-label branch November 17, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

Assignees

@adamtagscherer adamtagscherer

Labels
go Pull requests that update Go code provider:gcp Issues relating to the GCP provider test
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamtagscherer @chrisgacsal