Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(docker): change gateway port to 8080 #967

Merged
merged 1 commit into from
Nov 20, 2023
Merged

refactor(docker): change gateway port to 8080 #967

merged 1 commit into from
Nov 20, 2023

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Nov 20, 2023

Description

https://openclarity.io/docs/vmclarity/getting-started/install-vmclarity/#access-ui

The UI is accessible in all platforms at http://localhost:8080/ except for Docker where we use http://localhost:80/.

  • Change the port exposed on host to make Docker consistent with other platforms

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta requested a review from a team as a code owner November 20, 2023 14:04
@github-actions GitHub Actions
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr967-34867d8e0ec3d0616aed473d1f5301b9444fbdb2
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr967-34867d8e0ec3d0616aed473d1f5301b9444fbdb2
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr967-34867d8e0ec3d0616aed473d1f5301b9444fbdb2
  • ghcr.io/openclarity/vmclarity-ui-dev:pr967-34867d8e0ec3d0616aed473d1f5301b9444fbdb2
  • ghcr.io/openclarity/vmclarity-cli-dev:pr967-34867d8e0ec3d0616aed473d1f5301b9444fbdb2

@paralta paralta mentioned this pull request Nov 20, 2023
Merged
@paralta paralta self-assigned this Nov 20, 2023
@paralta paralta added docker Pull requests that update Docker code provider:docker Issues related to the docker provider labels Nov 20, 2023
@paralta paralta added this pull request to the merge queue Nov 20, 2023
Merged via the queue into main with commit e62288f Nov 20, 2023
33 checks passed
@paralta paralta deleted the docker-gateway-port branch November 20, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

Assignees

@paralta paralta

Labels
docker Pull requests that update Docker code provider:docker Issues related to the docker provider
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paralta @chrisgacsal