refactor(api): rework AssetScan General status #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamtagscherer
changed the title
This comment has been minimized.
This comment has been minimized.
adamtagscherer
force-pushed
the
general-asset-scan-status-refactor
branch
from
37f4702
to
bde5865
Compare
This comment has been minimized.
This comment has been minimized.
ramizpolic
previously approved these changes
Dec 6, 2023
chrisgacsal
requested changes
Dec 8, 2023
adamtagscherer
force-pushed
the
general-asset-scan-status-refactor
branch
from
c80df58
to
e5beefe
Compare
This comment has been minimized.
This comment has been minimized.
adamtagscherer
force-pushed
the
general-asset-scan-status-refactor
branch
from
e5beefe
to
58b69e6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
adamtagscherer
force-pushed
the
general-asset-scan-status-refactor
branch
from
e1838ff
to
84cd9fd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hey! Your images are ready:
|
chrisgacsal
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
AssetScan.Status.Generalproperty and moves it toAssetScan.Statusone step higher.Also it creates proper status states specific to the
AssetScanAPI object and enforces it's state transitions when calling the API.issue: #664
Type of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist