Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove torchdata #11

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Remove torchdata #11

merged 5 commits into from
Nov 22, 2023

Conversation

dfulu
Copy link
Member

@dfulu dfulu commented Nov 22, 2023

Pull Request

Description

Use datapipes from torch rather than torchdata. Similar to openclimatefix/PVNet#95

Also updated due to falling behind changes in pvnet

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have checked my code and corrected any misspellings

@dfulu dfulu changed the title Pytorch datapipes Remove torchdata Nov 22, 2023
@dfulu dfulu requested a review from jacobbieker November 22, 2023 11:34
Copy link
Member

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Other than the failing test

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (147f513) 68.28% compared to head (a6f2048) 59.53%.
Report is 25 commits behind head on main.

Files Patch % Lines
pvnet_summation/callbacks.py 0.00% 61 Missing ⚠️
pvnet_summation/data/datamodule.py 66.66% 3 Missing ⚠️
pvnet_summation/training.py 0.00% 2 Missing ⚠️
pvnet_summation/models/model.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   68.28%   59.53%   -8.75%     
==========================================
  Files           5        6       +1     
  Lines         413      472      +59     
==========================================
- Hits          282      281       -1     
- Misses        131      191      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfulu dfulu merged commit 2db8f05 into main Nov 22, 2023
4 of 6 checks passed
@dfulu dfulu deleted the pytorch_datapipes branch November 22, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants