Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ease of Setup improvements #212

Merged
merged 14 commits into from
Jan 5, 2024
Merged

Conversation

TomPughe
Copy link
Contributor

@TomPughe TomPughe commented Jan 4, 2024

Pull Request

Description

This issue includes some feature improvements to tackle issues I encountered when trying to run the module for the first time.

This is my first contribution to this code base so happy to get feedback on code style or any other aspect of my change

Features

  • Adds details of required environment variables required for running unit tests
  • Removes duplication of the folder name "latest" in utils by creating a function get_latest_subdir_path to retrieve the latest sub-folder name
  • In the new function to retrieve the latest sub-folder name, allows optionally for the latest sub-folder to be created if it doesn't already exist. This is used in the existing function move_older_files_to_different_location which requires the folder to exist
  • .gitignore update to cover files and folders created by the tool

How Has This Been Tested?

  • A unit test has been added for get_latest_subdir_path and run locally
  • Ran all unit tests locally to confirm they passed
  • Re-Ran the instructions "Downloading EUMETSAT Data" to ensure the latest folder was created automatically

No Changes to data processing

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link
Member

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks great!

@jacobbieker jacobbieker merged commit 3df6733 into openclimatefix:main Jan 5, 2024
1 of 2 checks passed
@peterdudfield
Copy link
Collaborator

@all-contributors please add @TomPughe for code

Copy link
Contributor

@peterdudfield

I've put up a pull request to add @TomPughe! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants