Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding Torch version 2.2.0 #89

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

aavashsubedi
Copy link
Contributor

@aavashsubedi aavashsubedi commented Mar 11, 2024

Excluding torch version 2.2.0 with Python 3.12 until fixed. pytorch/pytorch#110436
Also updated py-coverage versions and directory.

Pull Request

Description

I excluded the torch version 2.2.0 for Python version 3.12 within the testing "workflow.yaml". Also updated pytest-cov and passed the correct directory to the action.

Fixes #

How Has This Been Tested?

Tested on a fork of this repo with successful action.

  • [:white_check_mark: : ] Yes

Checklist:

  • [:heavy_check_mark: ] My code follows OCF's coding style guidelines
  • [:heavy_check_mark: ] I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • [ ✔️] I have checked my code and corrected any misspellings

Excluding torch version 2.2.0 with Python 3.12 until fixed. 
pytorch/pytorch#110436
Also updated py-coverage versions and directory.
@aavashsubedi
Copy link
Contributor Author

Just for reference. I could not test the uploading to cov-test since that requires a private token for the repo. See here: https://github.com/codecov/codecov-action
Changes to workflow action: https://github.com/aavashsubedi/graph_weather/actions/runs/8232862519

Copy link
Member

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for this!

@jacobbieker jacobbieker merged commit 967cf56 into openclimatefix:main Mar 11, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants