Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plot to evaluation #174

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

BraunRudolf
Copy link
Contributor

Pull Request

Description

adds plot of 10 first predictions to evaluation.py
Both lines are in separate graphs with same formatting.
with sample data:
newplot

Fixes #111

How Has This Been Tested?

Created plot with test data

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@BraunRudolf
Copy link
Contributor Author

Hi, I couldn't run the evaluation script due to an excessively long download time. I'll run it overnight and share the graph with data from the actual results_df. Please let me know if you have any changes.

@peterdudfield
Copy link
Contributor

Thanks, yea it takes about 40 hours I think.

@peterdudfield
Copy link
Contributor

Would you mind putting the predictions and actual on the same plot? Just so its more easy to compare. Thanks

@BraunRudolf
Copy link
Contributor Author

Will do!

@BraunRudolf
Copy link
Contributor Author

@peterdudfield In the issue, you state:

but would be good to get each forecast on its own plot

If you can clarify which forecasts you're referring to, I can implement it as well.
But, I'll download the data over the weekend, and then I'll run the code myself, which might help me better understand what you mean.

@peterdudfield
Copy link
Contributor

@peterdudfield In the issue, you state:

but would be good to get each forecast on its own plot

If you can clarify which forecasts you're referring to, I can implement it as well. But, I'll download the data over the weekend, and then I'll run the code myself, which might help me better understand what you mean.

Hi. Yea I think a plot for the forecast and the truth. And different plots of each site.

I think just testing it on the first is 10, but feel free to download data.

@BraunRudolf BraunRudolf marked this pull request as ready for review August 7, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add plots of 10 first predictions in evalution
2 participants