Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/gps filter #288

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Issue/gps filter #288

merged 5 commits into from
Sep 11, 2023

Conversation

peterdudfield
Copy link
Collaborator

@peterdudfield peterdudfield commented Sep 11, 2023

Pull Request

Description

Add filter gsp_ids to forecast/all and pvlive/all

Fixes #270

How Has This Been Tested?

  • CI tests

  • added tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield self-assigned this Sep 11, 2023
def test_read_truths_for_all_gsp(db_session, api_client):
"""Check main solar/GB/gsp/pvlive/all route works"""

def setup_gsp_yield_data(db_session):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactored test code and added a test

@peterdudfield peterdudfield marked this pull request as ready for review September 11, 2023 16:29
@peterdudfield peterdudfield merged commit d362eb9 into main Sep 11, 2023
1 check passed
@peterdudfield peterdudfield deleted the issue/gps-filter branch September 11, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add filter on gsp
2 participants