Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install cogutil lib under PREFIX/lib/opencog intead of PREDIX/lib #157

Merged
merged 1 commit into from
Dec 20, 2018

Conversation

ngeiswei
Copy link
Member

Fix #140

@ngeiswei
Copy link
Member Author

moses consistently fails on circleci but consistently passes on my systems. Can anybody else test that?

@vsbogd
Copy link
Contributor

vsbogd commented Dec 20, 2018

@ngeiswei , I have tried it in docker, as far as I see in moses cmake uses python 2.7 and nosetests with python 3. This is the reason why test fails.

@linas
Copy link
Member

linas commented Dec 20, 2018

So, the policy question becomes: do we merge anyway because we know "it works"? Or do we wait for a moses fix? (Since moses-python works with the old location, the fix for moses-python is to tell moses about the new location)

@vsbogd
Copy link
Contributor

vsbogd commented Dec 20, 2018

I see that I was not precise in my conclusion. Actually I am not sure that moses finds python2. What I saw is that test fails because it uses python3-nosetest and test itself is written using python2 syntax. I believe it is consequence of turning python unit tests on in opencog-deps. So may be solution is port python test to python3.

@linas
Copy link
Member

linas commented Dec 20, 2018

@vsbogd yes, everything needs to move to python3. But that does not explain why circleci pases with the old cogutils path. For that, I am attempting this: opencog/moses#77

@linas
Copy link
Member

linas commented Dec 20, 2018

Ohh.. that's interesting .. so, circleci passed here opencog/moses#74 but now it fails .. so indeed, @vsbogd, it seems that my explanation doesn't explain it; I suppose you're right..

@ngeiswei
Copy link
Member Author

Thanks guys, I'm merging since it's clear the problem doesn't come from that PR.

@ngeiswei ngeiswei merged commit f85718c into opencog:master Dec 20, 2018
@linas
Copy link
Member

linas commented Dec 20, 2018

I'm fixing the moses nosetests thing now. opencog/moses#78

@ngeiswei ngeiswei deleted the install-cogutil-opencog branch February 22, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants